Skip to content

backport(fix): optional everyone group in integration test #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2024
Merged

backport(fix): optional everyone group in integration test #281

merged 2 commits into from
Sep 6, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Sep 6, 2024 •
edited
Loading

backport #278
prerequisite for #280

@matifali matifali self-assigned this Sep 6, 2024
@matifali
Copy link
Member Author

matifali commented Sep 6, 2024

@ethanndickson I am backporting this test fix to merge #280 but it is still failing. Is there anything we need to backport?

@ethanndickson
Copy link
Member

ethanndickson commented Sep 6, 2024 •
edited
Loading

1.0 exposes both workspace.owner_groups and workspace_owner.groups, with one being deprecated, so I updated both, for both tests

@matifali matifali merged commit e3fb07e into release/1.0 Sep 6, 2024
12 checks passed
@matifali matifali deleted the maa/backport-278 branch September 6, 2024 05:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @ethanndickson